Flow: Prefer imported types from @babel/types over global BabelNode* types (#57752) - #57752
Open
robhogan wants to merge 1 commit into
Open
Flow: Prefer imported types from @babel/types over global BabelNode* types (#57752)#57752robhogan wants to merge 1 commit into
@babel/types over global BabelNode* types (#57752)#57752robhogan wants to merge 1 commit into
Conversation
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113574665. |
meta-cla
Bot
added
the
CLA Signed
…e*` types (#57752) Summary: ## Rationale Flow lib defs that declare global types (available anywhere, without an `import`) must be referenced in `.flowconfig` and can't be maintained incrementally. That's not too bad for very stable APIs and it's necessary for environment/runtime globals, but for 3P libraries it makes the lib defs much more difficult to maintain for little benefit (we have to import the runtime APIs anyway). Secondarily, it's a problem for generating TypeScript types, as TS doesn't declare any 3P library globally. Babel is one of few cases where a library declares Flow globals - every one has an importable equivalent. ## This diff Replaces usages of Babel global types across xplat/js with their `babel/types` equivalents Changelog: [Internal] Reviewed By: javache Differential Revision: D113574665
meta-codesync
Bot
changed the title
@babel/types over global BabelNode* types@babel/types over global BabelNode* types (#57752)
meta-codesync
Bot
force-pushed
the
export-D113574665
branch
from
July 29, 2026 13:31
6177523 to
06b2811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rationale
Flow lib defs that declare global types (available anywhere, without an
import) must be referenced in.flowconfigand can't be maintained incrementally. That's not too bad for very stable APIs and it's necessary for environment/runtime globals, but for 3P libraries it makes the lib defs much more difficult to maintain for little benefit (we have to import the runtime APIs anyway). Secondarily, it's a problem for generating TypeScript types, as TS doesn't declare any 3P library globally.Babel is one of few cases where a library declares Flow globals - every one has an importable equivalent.
This diff
Replaces usages of Babel global types across xplat/js with their
babel/typesequivalentsChangelog: [Internal]
Reviewed By: javache
Differential Revision: D113574665